nandorKollar commented on code in PR #3941: URL: https://github.com/apache/polaris/pull/3941#discussion_r2891959644
########## runtime/defaults/src/main/resources/application.properties: ########## @@ -58,7 +58,7 @@ quarkus.http.body.handle-file-uploads=false quarkus.http.limits.max-body-size=10240K quarkus.http.cors.origins=http://localhost:8080 -quarkus.http.cors.methods=PATCH, POST, DELETE, GET, PUT +quarkus.http.cors.methods=PATCH, POST, DELETE, GET, PUT, HEAD, OPTIONS Review Comment: It does, but only those, which have some non-default values no? If we don't set any default for `quarkus.http.cors.*`, just add `quarkus.http.cors.enabled=false`, then I think it is sufficient do document only `quarkus.http.cors.enabled` no? I'm wondering why `quarkus.http.cors.*` has any non-default value in our application properties, when cors is turned off? Is it because if someone turns it on, then we think that these values are the safest option? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
