dimas-b commented on code in PR #3941: URL: https://github.com/apache/polaris/pull/3941#discussion_r2892030935
########## runtime/defaults/src/main/resources/application.properties: ########## @@ -58,7 +58,7 @@ quarkus.http.body.handle-file-uploads=false quarkus.http.limits.max-body-size=10240K quarkus.http.cors.origins=http://localhost:8080 -quarkus.http.cors.methods=PATCH, POST, DELETE, GET, PUT +quarkus.http.cors.methods=PATCH, POST, DELETE, GET, PUT, HEAD, OPTIONS Review Comment: `quarkus.http.cors.*` values were added for [Polaris UI](https://github.com/apache/polaris-tools/tree/main/console), IIRC. Yet, if we switch to Quarkus default (which have wider scope), it should not hurt UI, I think. I think it is sufficient to document only what we explicitly change (or instruct users to change) in Polaris compared to Quarkus defaults. Interested users can always go to Quarkus config docs (which are pretty easy to navigate in my experience). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
