sungwy commented on code in PR #3999: URL: https://github.com/apache/polaris/pull/3999#discussion_r2937027371
########## polaris-core/src/main/java/org/apache/polaris/core/auth/FullyQualifiedPath.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.auth; + +import com.google.common.base.Preconditions; +import jakarta.annotation.Nullable; +import java.util.ArrayList; +import java.util.List; +import org.apache.polaris.core.entity.PolarisEntityType; +import org.apache.polaris.core.persistence.PolarisResolvedPathWrapper; +import org.apache.polaris.core.persistence.ResolvedPolarisEntity; + +/** Lexical fully qualified resource path split into leaf and ordered parent segments. */ +public record FullyQualifiedPath(PathSegment leaf, List<PathSegment> parents) { + + public FullyQualifiedPath { + Preconditions.checkNotNull(leaf, "leaf"); + Preconditions.checkNotNull(parents, "parents"); + parents = List.copyOf(parents); + } + + public static FullyQualifiedPath of( + PolarisSecurable securable, @Nullable String referenceCatalogName) { + List<PathSegment> namePartSegments = namePartSegments(securable); + Preconditions.checkState( + !namePartSegments.isEmpty(), + "FullyQualifiedPath produced no segments for entityType=%s nameParts=%s", + securable.getEntityType(), + securable.getNameParts()); + + int leafIndex = namePartSegments.size() - 1; + PathSegment leaf = namePartSegments.get(leafIndex); + List<PathSegment> parents = new ArrayList<>(); + if (isCatalogScopedType(securable.getEntityType())) { + Preconditions.checkArgument( + referenceCatalogName != null && !referenceCatalogName.isBlank(), + "referenceCatalogName must be non-empty for catalog-scoped securable entityType=%s nameParts=%s", + securable.getEntityType(), + securable.getNameParts()); + parents.add(new PathSegment(PolarisEntityType.CATALOG, referenceCatalogName)); + } + parents.addAll(namePartSegments.subList(0, leafIndex)); + return new FullyQualifiedPath(leaf, parents); + } + + /** + * Temporary adapter used while OPA serialization still accepts resolved paths alongside intent + * paths. Remove this overload when resolved-path callers are retired. + */ + public static FullyQualifiedPath of(PolarisResolvedPathWrapper wrapper) { + Preconditions.checkNotNull(wrapper, "wrapper"); + ResolvedPolarisEntity resolvedLeaf = wrapper.getResolvedLeafEntity(); + Preconditions.checkNotNull(resolvedLeaf, "wrapper.getResolvedLeafEntity()"); + + PathSegment leaf = + new PathSegment(resolvedLeaf.getEntity().getType(), resolvedLeaf.getEntity().getName()); + List<PathSegment> parents = new ArrayList<>(); + List<ResolvedPolarisEntity> resolvedParents = wrapper.getResolvedParentPath(); + if (resolvedParents != null) { + for (ResolvedPolarisEntity resolvedParent : resolvedParents) { + // Omit ROOT from fully qualified paths. It is an internal RBAC-only ancestor + if (resolvedParent.getEntity().getType() == PolarisEntityType.ROOT) { + continue; + } Review Comment: Note to reviewer: important behavior change to remove `ROOT` semantics from OPA request payload, since this is an RBAC-only semantic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
