sungwy commented on code in PR #3999: URL: https://github.com/apache/polaris/pull/3999#discussion_r2940485848
########## polaris-core/src/main/java/org/apache/polaris/core/auth/FullyQualifiedPath.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.auth; + +import com.google.common.base.Preconditions; +import jakarta.annotation.Nullable; +import java.util.ArrayList; +import java.util.List; +import org.apache.polaris.core.entity.PolarisEntityType; +import org.apache.polaris.core.persistence.PolarisResolvedPathWrapper; +import org.apache.polaris.core.persistence.ResolvedPolarisEntity; + +/** Lexical fully qualified resource path split into leaf and ordered parent segments. */ +public record FullyQualifiedPath(PathSegment leaf, List<PathSegment> parents) { Review Comment: > Having both models in polaris-core seems a bit overkill. I thought about this as well, I'm currently leaning towards keeping it in polaris-core because new PolarisAuthorizer implementations like the Ranger Authorizer may also need this. > This model is imho richer than PolarisSecurable. I wonder if you couldn't merge both models together, e.g.: I'm open to this idea. In order to correctly construct the parent though, we'd need to pass the `referenceCatalogName` to an arg referenceCatalogName arg here like ``` default PathSegment getParents(@Nullable String referenceCatalogName) { ... } ``` Would that make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
