tokoko commented on code in PR #3699:
URL: https://github.com/apache/polaris/pull/3699#discussion_r2997219952
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/io/StorageAccessConfigProvider.java:
##########
@@ -131,14 +144,30 @@ public StorageAccessConfig getStorageAccessConfig(
CredentialVendingContext credentialVendingContext =
buildCredentialVendingContext(tableIdentifier, resolvedPath);
+ RealmConfig realmConfig = callContext.getRealmConfig();
+
+ // Get the right integration for this storage type
+ String storageConfigStr =
+ storageInfoEntity
+ .getInternalPropertiesAsMap()
+ .get(PolarisEntityConstants.getStorageConfigInfoPropertyName());
+ PolarisStorageConfigurationInfo storageConfig =
+ PolarisStorageConfigurationInfo.deserialize(storageConfigStr);
+ var integration =
storageIntegrationProvider.getStorageIntegrationForConfig(storageConfig);
Review Comment:
yeah, that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
