dennishuo commented on code in PR #3699:
URL: https://github.com/apache/polaris/pull/3699#discussion_r3030808786
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageIntegrationProvider.java:
##########
@@ -21,11 +21,11 @@
import jakarta.annotation.Nullable;
/**
- * Factory interface that knows how to construct a {@link
PolarisStorageIntegration} given a {@link
+ * Factory interface that knows how to return a {@link
PolarisStorageIntegration} for a given {@link
* PolarisStorageConfigurationInfo}.
*/
public interface PolarisStorageIntegrationProvider {
<T extends PolarisStorageConfigurationInfo>
- @Nullable PolarisStorageIntegration<T> getStorageIntegrationForConfig(
+ @Nullable PolarisStorageIntegration<T> getStorageIntegration(
Review Comment:
This rename might actually help highlight the main discrepancy that will
cause issues here. The SPI contract via `IntegrationPersistence` defines the
ability to support stateful StorageIntegration objects. In the current status
quo, that means
`PolarisStorageIntegrationProvider.getStorageIntegrationForConfig` is more like
`constructProspectiveNewStorageIntegrationBasedOnConfig`.
It's an unfortunate shortcut that the same `PolarisStorageIntegration`
returned there is what holds a `getSubscopedCreds` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
