flyrain commented on code in PR #3997:
URL: https://github.com/apache/polaris/pull/3997#discussion_r2998358621
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -64,6 +64,18 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(false)
.buildFeatureConfiguration();
+ public static final FeatureConfiguration<Boolean>
OPTIMIZED_CREDENTIAL_VENDING =
+ PolarisConfiguration.<Boolean>builder()
+ .key("OPTIMIZED_CREDENTIAL_VENDING")
+ .catalogConfig("polaris.config.optimized-credential-vending")
+ .description(
+ "When enabled, the loadCredentials endpoint vends storage
credentials using "
+ + "location data from entity internal properties, avoiding a
full table metadata "
+ + "read from object storage. Falls back to the standard path
if the entity lacks "
+ + "the required properties.")
+ .defaultValue(false)
Review Comment:
I’d prefer not to introduce a flag. The logic should be robust enough to
handle different scenarios, regardless of whether locations are cached in the
catalog entity. It should fall back to metadata.json if not in the catalog
entity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
