singhpk234 commented on code in PR #3997:
URL: https://github.com/apache/polaris/pull/3997#discussion_r3005150566


##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -740,6 +738,71 @@ public Optional<LoadTableResponse> 
loadTableWithAccessDelegationIfStale(
         refreshCredentialsEndpoint);
   }
 
+  /**
+   * Vend credentials for a table using location data from entity internal 
properties, avoiding a
+   * full table metadata read from object storage. Falls back to the standard
+   * loadTableWithAccessDelegation path if the entity lacks the required 
properties.
+   */
+  public ImmutableLoadCredentialsResponse loadCredentialsFromEntityProperties(

Review Comment:
   I wonder if we should even allow RemoteCatalog aka External Catalogs ? 
external writes can happen independently of the external catalog without going 
through Polaris and our entities might not be consistent ?
   
   I added a check for now to only do this for catlaog owned by Polaris



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to