flyingImer commented on PR #4061: URL: https://github.com/apache/polaris/pull/4061#issuecomment-4179277198
@dimas-b I think your latest comments convinced me the shape issue is central enough to address in this PR. My current cut is to keep the scope narrow, but switch this SPI to a state/action model so callers no longer deal with raw `Object` state, and `TaskExecutorImpl` only deals with one captured object per propagator. I may still keep a generic cleanup hook with a default no-op, but the intent there would be generic lifecycle cleanup, not letting MDC shape the main propagation contract. I also plan to clean up the smaller `@Unremovable` and `RequestIdHolder` points while touching this area. Does that sound like the right cut? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
