flyingImer commented on code in PR #4061:
URL: https://github.com/apache/polaris/pull/4061#discussion_r3029952887
##########
runtime/service/src/main/java/org/apache/polaris/service/events/PolarisEventMetadataFactory.java:
##########
@@ -23,24 +23,23 @@
import io.quarkus.security.identity.CurrentIdentityAssociation;
import io.quarkus.security.identity.SecurityIdentity;
import jakarta.enterprise.context.ApplicationScoped;
+import jakarta.enterprise.context.ContextNotActiveException;
import jakarta.enterprise.inject.Instance;
import jakarta.inject.Inject;
import java.time.Clock;
import java.util.Map;
import java.util.Optional;
import org.apache.polaris.core.auth.PolarisPrincipal;
import org.apache.polaris.core.context.RealmContext;
-import org.apache.polaris.service.tracing.RequestIdFilter;
-import org.jboss.resteasy.reactive.server.core.CurrentRequestManager;
-import org.jboss.resteasy.reactive.server.core.ResteasyReactiveRequestContext;
-import org.jboss.resteasy.reactive.server.jaxrs.ContainerRequestContextImpl;
+import org.apache.polaris.core.context.RequestIdSupplier;
@ApplicationScoped
public class PolarisEventMetadataFactory {
@Inject Clock clock;
@Inject CurrentIdentityAssociation currentIdentityAssociation;
@Inject Instance<RealmContext> realmContext;
+ @Inject RequestIdSupplier requestIdSupplier;
Review Comment:
RequestIdSupplier is the read-only contract and this class only reads. It's
also what PersistingMetricsReporter uses, so keeping them consistent felt
right. Happy to revisit if you see a reason to diverge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
