dimas-b commented on code in PR #3699:
URL: https://github.com/apache/polaris/pull/3699#discussion_r3080140807
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/IntegrationPersistence.java:
##########
@@ -137,16 +142,4 @@ <T extends PolarisStorageConfigurationInfo> void
persistStorageIntegrationIfNeed
@Nonnull PolarisCallContext callContext,
@Nonnull PolarisBaseEntity entity,
@Nullable PolarisStorageIntegration<T> storageIntegration);
-
- /**
- * Load the polaris storage integration for a polaris entity
(Catalog,Namespace,Table,View)
- *
- * @param callContext the polaris call context
- * @param entity the polaris entity
- * @return a polaris storage integration
- */
- @Nullable
- <T extends PolarisStorageConfigurationInfo>
- PolarisStorageIntegration<T> loadPolarisStorageIntegration(
Review Comment:
+1 to @tokoko points. I also do not see any use case for this method in OSS,
still @dennishuo , please respond if you have any concerns from your side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]