Y-Wakuta commented on code in PR #4281:
URL: https://github.com/apache/polaris/pull/4281#discussion_r3214629248
##########
runtime/service/build.gradle.kts:
##########
@@ -208,6 +206,21 @@ dependencies {
tasks.named("javadoc") { dependsOn("jandex") }
+// MySQL is opt-in: the GPL JDBC driver (ASF Category X) is not bundled in the
default
+// build. Enable with `-PincludeMysqlDriver=true` to run the MySQL integration
tests.
+if (project.hasProperty("includeMysqlDriver")) {
Review Comment:
Thanks both — pushed an update: `runtime/service` now adds the MySQL JDBC
driver unconditionally, and `runtime/server` consolidates into a single
`if/else` that strips the driver by default (GPL-free) or keeps it under
`-PincludeMysqlDriver=true`. This also fixes the CI failure where
`MysqlApplicationIT` was hitting `ClassNotFoundException:
com.mysql.jdbc.Driver` without the flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
