Y-Wakuta commented on code in PR #4281:
URL: https://github.com/apache/polaris/pull/4281#discussion_r3214640708
##########
runtime/service/src/intTest/java/org/apache/polaris/service/it/relational/mysql/MysqlApplicationIT.java:
##########
@@ -16,19 +16,13 @@
* specific language governing permissions and limitations
* under the License.
*/
+package org.apache.polaris.service.it.relational.mysql;
-plugins {
- id("org.kordamp.gradle.jandex")
- id("polaris-server")
-}
+import io.quarkus.test.junit.QuarkusIntegrationTest;
+import io.quarkus.test.junit.TestProfile;
+import org.apache.polaris.service.it.test.PolarisApplicationIntegrationTest;
+import org.apache.polaris.test.commons.MysqlRelationalJdbcProfile;
-dependencies {
- api(platform(libs.testcontainers.bom))
- api("org.testcontainers:testcontainers")
-
- implementation(project(":polaris-container-spec-helper"))
- implementation(libs.guava)
-
- compileOnly(platform(libs.junit.bom))
- compileOnly("org.junit.jupiter:junit-jupiter-api")
-}
+@TestProfile(MysqlRelationalJdbcProfile.class)
+@QuarkusIntegrationTest
+public class MysqlApplicationIT extends PolarisApplicationIntegrationTest {}
Review Comment:
The tests themselves were already picked up unconditionally (no gating
annotation) — technically they ran on every CI build, just failing without the
flag because the MySQL driver wasn't on the classpath (`ClassNotFoundException:
com.mysql.jdbc.Driver`). Thanks for raising this — the change in the
`runtime/service`/`runtime/server` thread above adds the driver unconditionally
too, so the tests now would pass on every CI build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
