dimas-b commented on code in PR #4404:
URL: https://github.com/apache/polaris/pull/4404#discussion_r3227017322
##########
runtime/service/src/main/java/org/apache/polaris/service/ratelimiter/RateLimiterFilter.java:
##########
@@ -74,7 +76,16 @@ public void filter(ContainerRequestContext ctx) throws
IOException {
EventAttributes.REQUEST_URI,
ctx.getUriInfo().getAbsolutePath().toString())));
}
-
ctx.abortWith(Response.status(Response.Status.TOO_MANY_REQUESTS).build());
+ ctx.abortWith(
+ Response.status(Response.Status.TOO_MANY_REQUESTS)
+ .type(MediaType.APPLICATION_JSON_TYPE)
+ .entity(
+ ErrorResponse.builder()
Review Comment:
This response form is specific to the Iceberg REST API, but the filter
covers all Polaris REST API, IIRC... I'm not sure using this response form is
relevant to all of them.
... especially considering that changing the response payload after we
release with _some_ payload is going to be very difficult.
Is there a way to restrict this to IRC endpoints?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
