dimas-b commented on code in PR #4404:
URL: https://github.com/apache/polaris/pull/4404#discussion_r3237666807
##########
runtime/service/src/main/java/org/apache/polaris/service/ratelimiter/RateLimiterFilter.java:
##########
@@ -74,7 +76,16 @@ public void filter(ContainerRequestContext ctx) throws
IOException {
EventAttributes.REQUEST_URI,
ctx.getUriInfo().getAbsolutePath().toString())));
}
-
ctx.abortWith(Response.status(Response.Status.TOO_MANY_REQUESTS).build());
+ ctx.abortWith(
+ Response.status(Response.Status.TOO_MANY_REQUESTS)
+ .type(MediaType.APPLICATION_JSON_TYPE)
+ .entity(
+ ErrorResponse.builder()
Review Comment:
So, that does look like an IRC error response payload... while I do not
agree with this approach for Polaris' own API, this is the state of the project
ATM.
Therefore, it makes sense to use the same payload structure for 429
responses too.
Thanks for the pointers, @travis-bowen :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
