snazy commented on PR #4240: URL: https://github.com/apache/polaris/pull/4240#issuecomment-4433762247
The jspecify migration makes a lot of sense to me and I'd love to see this eventually land across the code base. What I'm concerned about is the immutable-warnings saying that not all properties are correctly handled, but the build passes. Omitting a property during a `.from()` can cause, as the warning message says, appears worrisome and, assuming the warning message is correct there, could lead to issues causing undetected failure scenarios. The mentioned issue only affects some test-fixtures in a currently harmless way. That's okay for me, as the tests still pass. I'd feel more comfortable to wait until https://github.com/immutables/immutables/issues/1655 has been fixed and the warnings disappears. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
