flyrain commented on PR #4240:
URL: https://github.com/apache/polaris/pull/4240#issuecomment-4443259398

   > My understanding is that this PR does introduce new warnings
   
   What are they?
   
   If you run `./gradlew :polaris-persistence-nosql-api:compileTestFixturesJava 
--rerun` against the current main, the warnings are there already.
   
   ```
   > Task :polaris-persistence-nosql-api:compileTestFixturesJava
   
/Users/ygu/asf/polaris/persistence/nosql/persistence/api/src/testFixtures/java/org/apache/polaris/persistence/nosql/api/obj/SimpleTestObj.java:33:
 warning: (immutables) Type parsing problem in FromSupertypesModel: 
java.lang.IllegalArgumentException: Cannot parse type from input string 'byte 
@org.jspecify.annotations.Nullable []'. unexpected trailing terms 
'@org.jspecify.annotations.Nullable[]'
   public interface SimpleTestObj extends Obj {
          ^
           at 
org.immutables.value.processor.encode.Type$Parser.doParse(Type.java:940)
   
/Users/ygu/asf/polaris/persistence/nosql/persistence/api/src/testFixtures/java/org/apache/polaris/persistence/nosql/api/obj/SimpleTestObj.java:33:
 warning: (immutables:from) Generated builder '.from' method will not copy from 
attribute 'binary' because it has some not-yet-generated type, or different 
return type in supertype  (we cannot handle generic specialization or covariant 
overrides yet). Sometimes it is possible to avoid this by providing abstract 
override method in this value object
   public interface SimpleTestObj extends Obj {
          ^
   
/Users/ygu/asf/polaris/persistence/nosql/persistence/api/src/testFixtures/java/org/apache/polaris/persistence/nosql/api/obj/AnotherTestObj.java:33:
 warning: (immutables:from) Generated builder '.from' method will not copy from 
attribute 'binary' because it has some not-yet-generated type, or different 
return type in supertype  (we cannot handle generic specialization or covariant 
overrides yet). Sometimes it is possible to avoid this by providing abstract 
override method in this value object
   public interface AnotherTestObj extends Obj {
          ^
   
/Users/ygu/asf/polaris/persistence/nosql/persistence/api/src/testFixtures/java/org/apache/polaris/persistence/nosql/api/obj/VersionedTestObj.java:30:
 warning: (immutables:from) Generated builder '.from' method will not copy from 
attribute 'binary' because it has some not-yet-generated type, or different 
return type in supertype  (we cannot handle generic specialization or covariant 
overrides yet). Sometimes it is possible to avoid this by providing abstract 
override method in this value object
   public interface VersionedTestObj extends Obj {
          ^
   
/Users/ygu/asf/polaris/persistence/nosql/persistence/api/src/testFixtures/java/org/apache/polaris/persistence/nosql/api/obj/CommitTestObj.java:33:
 warning: (immutables:from) Generated builder '.from' method will not copy from 
attribute 'binary' because it has some not-yet-generated type, or different 
return type in supertype  (we cannot handle generic specialization or covariant 
overrides yet). Sometimes it is possible to avoid this by providing abstract 
override method in this value object
   public interface CommitTestObj extends BaseCommitObj {
          ^
   5 warnings
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to