sririshindra commented on code in PR #4225: URL: https://github.com/apache/polaris/pull/4225#discussion_r3231017166
########## runtime/service/src/main/java/org/apache/polaris/service/events/listeners/PersistenceEventHandler.java: ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.service.events.listeners; + +import org.apache.polaris.service.events.PolarisEvent; + +interface PersistenceEventHandler { Review Comment: Thanks @adutra — I agree this should ultimately be a global concern. In this revision, I've extracted the filtering and pruning logic into two public interfaces at the events package level (not within listeners): - EventAttributeFilter — decides which AttributeKeys are safe to pass downstream - EventPayloadPruner — reduces large attribute values (especially TableMetadata) to bounded summaries Both are CDI beans with no coupling to persistence. They can be promoted to PolarisEventListeners.deliverEvent() as a global pre-delivery sanitizer once we reach community consensus on that approach. I will send an email to the mailing list for this. For now they're functional within the persistence listener but architecturally ready to move. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
