nandorKollar commented on code in PR #4225:
URL: https://github.com/apache/polaris/pull/4225#discussion_r3298921861
##########
runtime/service/src/main/java/org/apache/polaris/service/events/PolarisEventListeners.java:
##########
@@ -80,8 +82,13 @@ public void onStartup(@Observes StartupEvent event) {
private void deliverEvent(
PolarisEvent event, String listenerName, PolarisEventListener listener) {
LOGGER.debug("Delivering {} event to listener '{}' ({})", event.type(),
listenerName, listener);
+ // TODO: Add an opt-in mechanism (e.g., a marker interface or annotation)
for specialized
Review Comment:
I think either a marker interface, or an extra method on
`PolarisEventListener` with a default implement could address this. Something
like this:
```
default boolean acceptUnsanitizedEvent() {
return false;
}
```
##########
runtime/service/src/main/java/org/apache/polaris/service/events/PolarisEventListeners.java:
##########
@@ -80,8 +82,13 @@ public void onStartup(@Observes StartupEvent event) {
private void deliverEvent(
PolarisEvent event, String listenerName, PolarisEventListener listener) {
LOGGER.debug("Delivering {} event to listener '{}' ({})", event.type(),
listenerName, listener);
+ // TODO: Add an opt-in mechanism (e.g., a marker interface or annotation)
for specialized
Review Comment:
I think either a marker interface, or an extra method on
`PolarisEventListener` with a default implement could address this. Something
like this:
```
default boolean acceptUnsanitizedEvent() {
return false;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
