jbonofre commented on code in PR #4422:
URL: https://github.com/apache/polaris/pull/4422#discussion_r3231634331
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##########
@@ -882,6 +882,33 @@ private void validateUpdateCatalogDiffOrThrow(
}
}
+ private void validateBaseLocationAgainstStorageConfig(
Review Comment:
nit: maybe worth to add a test on this path to verify.
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##########
@@ -918,6 +945,13 @@ private void validateUpdateCatalogDiffOrThrow(
// New base location is already in the updated properties; we'll also
potentially
// plumb it into the logic for setting an updated
StorageConfigurationInfo.
defaultBaseLocation = newDefaultBaseLocation;
+
+ // If the storage config is not being updated, validate that the new
base location
+ // is allowed by the existing storage configuration to prevent
inconsistent state.
+ if (updateRequest.getStorageConfigInfo() == null) {
Review Comment:
Maybe we can also check if the new location is different from the current
one. It will accelerate and avoid any side effect.
```suggestion
if (updateRequest.getStorageConfigInfo() == null
&&
!newDefaultBaseLocation.equals(currentCatalogEntity.getBaseLocation())) {
```
That could be done before `defaultBaseLocation = newDefaultBaseLocation;`
also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
