visit2rahul commented on PR #4422: URL: https://github.com/apache/polaris/pull/4422#issuecomment-4467807678
Thanks for the review @dimas-b — addressed your 3 points in `a3167bcba`: - `test_cli.py` — removed `test_update_catalog_base_location_validation` (server-side coverage is in `BaseLocationValidationTest`). - `BaseLocationValidationTest` — combined `testChildLocationIsAccepted` + `testExactMatchIsAccepted` into one `@ParameterizedTest`. - `testNullStorageConfigSkipsValidation` — kept as-is; reasoning + citations to the parallel patterns (`validateUpdateCatalogDiffOrThrow`, `getCatalogLocations`, `CatalogEntity.Builder`) posted inline on the L107 thread. CI should re-run automatically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
