jbonofre commented on code in PR #4420: URL: https://github.com/apache/polaris/pull/4420#discussion_r3231666833
########## extensions/auth/ranger/impl/src/main/java/org/apache/polaris/extension/auth/ranger/RangerPolarisAuthorizer.java: ########## Review Comment: I believe this is not used anymore with your change. ########## polaris-core/src/main/java/org/apache/polaris/core/auth/AuthorizationPreConditions.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.auth; + +import org.apache.iceberg.exceptions.ForbiddenException; +import org.apache.polaris.core.entity.PolarisEntityConstants; + +/** + * Common pre-condition checks shared across authorizer implementations for credential-related + * operations. + */ +public final class AuthorizationPreConditions { Review Comment: I would suggest to add a unit test with the different conditions: - flag off, no exception, regardless of property/op - flag on + rotation property absent, no exception - flag on + rotation property present + op == ROTATE_CREDENTIALS, no exception - flag on + rotation property present + op != ROTATE_CREDENTIALS, ForbiddenException -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
