visit2rahul commented on code in PR #4420: URL: https://github.com/apache/polaris/pull/4420#discussion_r3278167408
########## polaris-core/src/main/java/org/apache/polaris/core/auth/AuthorizationPreConditions.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.auth; + +import org.apache.iceberg.exceptions.ForbiddenException; +import org.apache.polaris.core.entity.PolarisEntityConstants; + +/** + * Common pre-condition checks shared across authorizer implementations for credential-related + * operations. + */ +public final class AuthorizationPreConditions { + + private AuthorizationPreConditions() {} + + /** + * Checks whether the principal is required to rotate credentials before performing the requested + * operation. If the principal has the {@code PRINCIPAL_CREDENTIAL_ROTATION_REQUIRED_STATE} + * property set, only {@link PolarisAuthorizableOperation#ROTATE_CREDENTIALS} is allowed. + * + * @param polarisPrincipal the principal attempting the operation + * @param authzOp the operation being attempted + * @param enforceCredentialRotationRequiredState whether the enforcement flag is enabled + * @throws ForbiddenException if the principal must rotate credentials first + */ + public static void checkCredentialRotationRequired( + PolarisPrincipal polarisPrincipal, + PolarisAuthorizableOperation authzOp, + boolean enforceCredentialRotationRequiredState) { Review Comment: Thank you @dimas-b. Pushed 3e671fad8 implementing the refactor as confirmed: - `checkCredentialRotationRequired` now takes `RealmConfig` and reads the `ENFORCE_PRINCIPAL_CREDENTIAL_ROTATION_REQUIRED_CHECKING` flag internally - Removed the duplicate flag lookups from `PolarisAuthorizerImpl` and `RangerPolarisAuthorizer` - `AuthorizationPreConditionsTest` uses a small mock-`RealmConfig` helper across all 4 cases @jbonofre @dimas-b please review as your time permits. As a first-time contributor, CI requires a committer to approve the workflow run on this push - happy to iterate once it runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
