jbonofre commented on code in PR #4417:
URL: https://github.com/apache/polaris/pull/4417#discussion_r3231715836


##########
persistence/nosql/idgen/impl/src/main/java/org/apache/polaris/ids/impl/SnowflakeIdGeneratorImpl.java:
##########
@@ -54,6 +54,9 @@ class SnowflakeIdGeneratorImpl implements 
SnowflakeIdGenerator {
 
   // TODO add a specialized implementation using hard-coded values for the 
standardized parameters
 
+  @VisibleForTesting static final long TIME_UUID_EPOCH_OFFSET_100NS = 
0x01b21dd213814000L;

Review Comment:
   nit: Maybe a small comment here would help the reviewer (at least it would 
have helped me 😄 ).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to