flyrain commented on code in PR #4417:
URL: https://github.com/apache/polaris/pull/4417#discussion_r3238370212
##########
persistence/nosql/idgen/impl/src/test/java/org/apache/polaris/ids/impl/TestSnowflakeIdGeneratorImpl.java:
##########
@@ -559,12 +564,30 @@ void spinWaitSequence() {
() ->
impl.timeUuidToId(
new UUID(
- timeUuidMsbReal((1L << DEFAULT_TIMESTAMP_BITS) - 1),
+ timeUuidMsbReal(
+ timeUuidTimestampFromUnixMillis(
+ ID_EPOCH_MILLIS + ((1L <<
DEFAULT_TIMESTAMP_BITS) - 2))),
timeUuidLsb(
(1L << DEFAULT_SEQUENCE_BITS) - 1, (1L <<
DEFAULT_NODE_ID_BITS) - 1))))
.doesNotThrowAnyException();
}
+ @Test
+ public void timeUuidUsesStandardTimestampEncoding() {
+ var nodeId = 42;
+ var timestamp = TimeUnit.DAYS.toMillis(365);
+ var impl =
+ new SnowflakeIdGeneratorImpl(idGeneratorSource(nodeId, () ->
ID_EPOCH_MILLIS + timestamp));
+ var id = impl.constructId(timestamp, 7, nodeId);
+ var uuid = impl.idToTimeUuid(id);
+
+ soft.assertThat(uuid.timestamp())
+ .isEqualTo(timeUuidTimestampFromUnixMillis(ID_EPOCH_MILLIS +
timestamp));
+ soft.assertThat(unixMillisFromTimeUuidTimestamp(uuid.timestamp()))
+ .isEqualTo(ID_EPOCH_MILLIS + timestamp);
+ soft.assertThat(impl.timeUuidToId(uuid)).isEqualTo(id);
+ }
+
Review Comment:
minor: add a negative test for `unixMillisFromTimeUuidTimestamp` rejecting a
non-tick-aligned input (the `% TICKS_PER_MILLISECOND == 0` branch), which is
currently uncovered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
