sungwy commented on code in PR #4409:
URL: https://github.com/apache/polaris/pull/4409#discussion_r3238642072
##########
polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizer.java:
##########
@@ -38,26 +39,85 @@ public interface PolarisAuthorizer {
* <p>This method should not perform authorization decisions directly.
*/
void resolveAuthorizationInputs(
- @Nonnull AuthorizationState authzState, @Nonnull AuthorizationRequest
request);
+ @Nonnull AuthorizationState authzState,
+ @Nonnull PolarisPrincipal polarisPrincipal,
Review Comment:
Hi @flyrain - I really like this suggestion. I think the
`AuthorizationIntent` / `AuthorizationRequest(subject, intents)` split is a
cleaner model, especially since the sealed hierarchy is really describing
action/resource shape rather than the full authorization request.
I agree that this is a great time to review the shape with scrutiny, as we
have an opportunity to come to a strong consensus before we migrate the handler
call sites.
If we are in agreement, I can go ahead and adopt this suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
