dimas-b commented on code in PR #4409:
URL: https://github.com/apache/polaris/pull/4409#discussion_r3243461833
##########
polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizer.java:
##########
@@ -38,26 +39,85 @@ public interface PolarisAuthorizer {
* <p>This method should not perform authorization decisions directly.
*/
void resolveAuthorizationInputs(
- @Nonnull AuthorizationState authzState, @Nonnull AuthorizationRequest
request);
+ @Nonnull AuthorizationState authzState,
+ @Nonnull PolarisPrincipal polarisPrincipal,
Review Comment:
Side note: the need to make `PolarisPrincipal` and `RealmContext` explicit
in the Authorizer Backend SPI is based purely on our standing design principle
that `polaris-core` should be neutral to CDI. The API/SPI split I mentioned
above is basically a manifestation of CDI context in terms of `polaris-core`
classes. If we adopted CDI throughout the Polaris codebase, this design could
be simplified (but I do not mean to make this change now... just sharing my
POV).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
