tokoko commented on code in PR #3699:
URL: https://github.com/apache/polaris/pull/3699#discussion_r3242269045
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -1251,31 +1250,23 @@ private List<PolarisPolicyMappingRecord>
fetchPolicyMappingRecords(
@Nullable
@Override
- public <T extends PolarisStorageConfigurationInfo>
- PolarisStorageIntegration<T> createStorageIntegration(
- @Nonnull PolarisCallContext callCtx,
- long catalogId,
- long entityId,
- PolarisStorageConfigurationInfo polarisStorageConfigurationInfo) {
- return storageIntegrationProvider.getStorageIntegrationForConfig(
- polarisStorageConfigurationInfo);
+ public PolarisStorageIntegration createStorageIntegration(
+ @Nonnull PolarisCallContext callCtx,
+ long catalogId,
+ long entityId,
+ PolarisStorageConfigurationInfo polarisStorageConfigurationInfo) {
+ // No-op in OSS: the storage integration is resolved at credential-vending
time via
+ //
PolarisStorageIntegrationProvider.getStorageIntegration(resolvedEntityPath).
This hook
+ // remains available for custom deployments that need to allocate/lease
external state
+ // atomically with the catalog-creation transaction.
+ return null;
Review Comment:
I think this was deliberate, otherwise I'd push for deletion of these
methods as well. JdbcMetaStoreManagerFactory uses
AtomicOperationMetaStoreManager which invokes both storage persistence methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
