snazy commented on PR #4439: URL: https://github.com/apache/polaris/pull/4439#issuecomment-4458068471
I do not think this validation adds coverage. The LICENSE/NOTICE files are produced by `licenseNoticeMerge`, which consumes the `licenseNoticeElements` configurations from polaris-admin and polaris-server. `LicenseNoticeMerge` unconditionally reads both `LICENSE` and `NOTICE` from each input directory, so a missing file already fails the distribution build. This task also only validates presence by archive entry name; it does not cover the content/staleness checks requested in #4186. The existing admin/server checks already validate mentioned dependencies. So this change seems redundant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
