RussellSpitzer commented on code in PR #4454: URL: https://github.com/apache/polaris/pull/4454#discussion_r3259729172
########## AGENTS.md: ########## @@ -66,6 +66,27 @@ assumptions and running with them without checking. --- +## Do Not Treat Issues As Specifications [DISCIPLINE] + +A GitHub issue is a starting point for investigation, not an implementation plan. +Before making an issue-driven change, verify that the requested behavior is still +missing and that the proposed fix actually addresses the stated problem. + +Required workflow: + +1. Trace the current code path related to the issue. +2. Search for existing validation, tests, build tasks, or runtime behavior that may + already cover the requested case. +3. Compare the issue's requested failure modes with the change you intend to make. + If the change only addresses part of the issue, use `Related to #NNN`, not + `Fixes #NNN`. +4. Do not add redundant checks. If existing code already fails, validates, or tests Review Comment: This could probably just be added to the above section (Understand before Coding) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
