flyrain commented on code in PR #4454: URL: https://github.com/apache/polaris/pull/4454#discussion_r3263081319
########## AGENTS.md: ########## @@ -229,6 +253,11 @@ Write the minimum code that solves the problem. Start with the simplest correct implementation. Optimize only when the task requires it, and only after the simple version works and has tests. +When reading from a database, object store, filesystem, archive, or other external +data source, do not materialize unbounded inputs just to perform existence checks. +Prefer streaming, short-circuiting, indexed lookups, or existing APIs. If collecting +is necessary, the bound must be obvious from the code or explained in the PR. Review Comment: Does it belong to the section of Simplicity? I'd move it to a section like IO handling as a general suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
