dimas-b commented on code in PR #4472:
URL: https://github.com/apache/polaris/pull/4472#discussion_r3267203203
##########
persistence/nosql/persistence/testextension/src/main/java/org/apache/polaris/persistence/nosql/testextension/PersistenceTestExtension.java:
##########
@@ -165,11 +165,11 @@ public boolean supportsParameter(
}
private void assertValidFieldCandidate(Field field) {
- if (!field.getType().isAssignableFrom(SnowflakeIdGenerator.class)
- && !field.getType().isAssignableFrom(MonotonicClock.class)
- && !field.getType().isAssignableFrom(Persistence.class)
- && !field.getType().isAssignableFrom(Backend.class)
- && !field.getType().isAssignableFrom(BackendTestFactory.class)) {
+ if (!IdGenerator.class.isAssignableFrom(field.getType())
+ && !MonotonicClock.class.isAssignableFrom(field.getType())
Review Comment:
This extension actually produces a `MonotonicClock` (among other types here)
and JUnit will assign that value to the field.... so the old check looks
correct to me 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
