dimas-b commented on code in PR #4472:
URL: https://github.com/apache/polaris/pull/4472#discussion_r3267897304
##########
persistence/nosql/persistence/testextension/src/main/java/org/apache/polaris/persistence/nosql/testextension/PersistenceTestExtension.java:
##########
@@ -120,10 +121,10 @@ public Object resolveParameter(
private Object resolve(
PolarisPersistence annotation, Class<?> type, ExtensionContext
extensionContext) {
- if (MonotonicClock.class.isAssignableFrom(type)) {
+ if (MonotonicClock.class == type) {
return getOrCreateMonotonicClock(extensionContext);
}
- if (IdGenerator.class.isAssignableFrom(type)) {
+ if (IdGenerator.class == type || SnowflakeIdGenerator.class == type) {
Review Comment:
nit: Why not `type.isAssignableFrom(SnowflakeIdGenerator.class)`? I believe
that would fit the overall parameter injection logic better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
