dimas-b commented on code in PR #4491:
URL: https://github.com/apache/polaris/pull/4491#discussion_r3268922834
##########
runtime/service/src/test/java/org/apache/polaris/service/admin/PolarisS3InteroperabilityTest.java:
##########
@@ -134,6 +135,7 @@ private GetNamespaceResponse createNamespace(
.createNamespace(
catalogName,
createNamespaceRequest,
+ new UUID(0L, 0L) /* TODO UUID v7 */,
Review Comment:
Why not use a fixed UUID v7 now?
##########
plugins/spark/v3.5/spark/src/test/java/org/apache/polaris/spark/SparkCatalogTest.java:
##########
@@ -158,6 +158,7 @@ public void setup() throws Exception {
.thenReturn("/tmp/test-warehouse");
Mockito.when(mockedSession.sparkContext()).thenReturn(mockedContext);
Mockito.when(mockedContext.applicationId()).thenReturn("appId");
+ Mockito.when(mockedContext.appName()).thenReturn("test-app");
Review Comment:
nit: is it required for Iceberg 1.11? Why? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
