adutra commented on code in PR #4491:
URL: https://github.com/apache/polaris/pull/4491#discussion_r3269545367
##########
plugins/spark/v3.5/spark/src/test/java/org/apache/polaris/spark/SparkCatalogTest.java:
##########
@@ -158,6 +158,7 @@ public void setup() throws Exception {
.thenReturn("/tmp/test-warehouse");
Mockito.when(mockedSession.sparkContext()).thenReturn(mockedContext);
Mockito.when(mockedContext.applicationId()).thenReturn("appId");
+ Mockito.when(mockedContext.appName()).thenReturn("test-app");
Review Comment:
Confirmed: https://github.com/apache/iceberg/pull/14976 added a new
mandatory attribute `app-name` to `EnvironmentContext`.
Without this changes all tests in this class fail with:
```
java.lang.NullPointerException
at
java.base/java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011)
at
java.base/java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1006)
at org.apache.iceberg.EnvironmentContext.put(EnvironmentContext.java:53)
at
org.apache.iceberg.spark.SparkCatalog.initialize(SparkCatalog.java:800)
at
org.apache.polaris.spark.SparkCatalogTest$InMemorySparkCatalog.initialize(SparkCatalogTest.java:104)
at
org.apache.polaris.spark.SparkCatalogTest.setup(SparkCatalogTest.java:169)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
