sungwy commented on code in PR #4409: URL: https://github.com/apache/polaris/pull/4409#discussion_r3270785255
########## polaris-core/src/main/java/org/apache/polaris/core/auth/AuthorizationIntent.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.auth; + +import jakarta.annotation.Nonnull; +import jakarta.annotation.Nullable; +import org.apache.polaris.core.entity.PolarisEntityType; + +/** Authorization intent describing an operation and its target resource shape. */ +public sealed interface AuthorizationIntent + permits TargetlessAuthorizationIntent, + SingleTargetAuthorizationIntent, + PairwiseTargetAuthorizationIntent { + static AuthorizationIntent of(@Nonnull PolarisAuthorizableOperation operation) { + return new TargetlessAuthorizationIntent(operation); + } + + static AuthorizationIntent of( + @Nonnull PolarisAuthorizableOperation operation, @Nonnull PolarisSecurable target) { + return new SingleTargetAuthorizationIntent(operation, target); + } + + static AuthorizationIntent of( + @Nonnull PolarisAuthorizableOperation operation, + @Nullable PolarisSecurable target, + @Nullable PolarisSecurable secondary) { + return new PairwiseTargetAuthorizationIntent(operation, target, secondary); + } + + @Nonnull + PolarisAuthorizableOperation getOperation(); + + @Nullable + PolarisSecurable getTarget(); Review Comment: Thanks for the thoughtful comment, @flyrain. I share a similar concern. One thing I do want to optimize for here though is compatibility across `PolarisAuthorizer` implementations. I’m a bit hesitant to require every downstream consumer to know the full set of `AuthorizationIntent` children and switch over them in order to support the SPI. In hindsight, keeping target / secondary as separate parent accessors has a very similar tradeoff in the case of the example you described, so I agree that is not a great long-term answer either. One idea I had was to introduce a compatibility accessor like `asAuthorizationTuple()` on `AuthorizationIntent`, implemented by each subtype. The idea would be that each intent can project itself into a normalized tuple shape that downstream consumers can use for payload construction without having to switch on the subtype directly. My hope is that this gives us a better way to take advantage of the sealed hierarchy for construction, while still keeping the downstream consumer contract relatively stable. Curious what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
