adutra commented on PR #4487: URL: https://github.com/apache/polaris/pull/4487#issuecomment-4497869534
> in case in the future, synchronized from `UnicastProcessor.onNext` is removed, then the extra locking in this PR makes sense. As the contract of `UnicastProcessor` doesn't state, that it is safe to use in multi-threaded environment, it might change in the future. @visit2rahul @adutra what do you think? Yes, I'm going back and forth about this as well. I honestly don't think that Mutiny would ever change their `UnicastProcessor` implementation and remove the `synchronized` keyword; on the other hand, this isn't part of the Reactive Streams spec. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
