visit2rahul commented on PR #4487: URL: https://github.com/apache/polaris/pull/4487#issuecomment-4504320779
Thank you @adutra. The EventProcessor wrapper you proposed is a sound future-proofing improvement. That said, this PR already has consensus as the doc-only re-scope after @nandorKollar's finding. I do not think we should relitigate it. I would strongly propose we let this PR land as doc with added comment for readability as prior consensus - though of course the merge call rests with you and the other committers. I will adopt your alternative architecture in #4498 - that is the right place for the own-sync change, and it also answers @flyrain's testability question. @jbonofre @dimas-b @nandorKollar - any objection to the split? Please review as your time permits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
