adutra commented on code in PR #4508:
URL: https://github.com/apache/polaris/pull/4508#discussion_r3274507193
##########
polaris-core/src/main/java/org/apache/polaris/core/rest/NamespaceUtils.java:
##########
@@ -35,6 +35,19 @@ public final class NamespaceUtils {
*/
public static final String DEFAULT_NAMESPACE_SEPARATOR = "\u001f";
+ /**
+ * The default namespace separator, percent-encoded to "%1F".
+ *
+ * <p>This is the same encoded separator declared in Iceberg's {@link
+ * org.apache.iceberg.rest.RESTUtil} class, but it's package-private there
and cannot be
+ * referenced.
+ *
+ * <p>This value is also exposed in {@link
+ *
org.apache.iceberg.rest.RESTCatalogProperties#NAMESPACE_SEPARATOR_DEFAULT} –
but here we avoid
+ * referencing that field directly since we don't own it.
+ */
+ public static final String DEFAULT_NAMESPACE_SEPARATOR_ENCODED = "%1F";
Review Comment:
That's the _opposite_ of what we should do 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
