dimas-b commented on code in PR #4508:
URL: https://github.com/apache/polaris/pull/4508#discussion_r3276425838
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -1436,10 +1438,16 @@ public ConfigResponse getConfig() {
Map<String, String> properties =
PolarisEntity.of(resolvedReferenceCatalog.getEntity()).getPropertiesAsMap();
- String prefix = prefixParser().catalogNameToPrefix(catalogName());
return ConfigResponse.builder()
.withDefaults(properties) // catalog properties are defaults
- .withOverrides(ImmutableMap.of("prefix", prefix))
+ .withOverrides(
+ ImmutableMap.of(
+ "prefix",
+ prefixParser().catalogNameToPrefix(catalogName()),
+ // Polaris does not handle custom namespace separators;
+ // always communicate the default namespace separator to
clients.
+ RESTCatalogProperties.NAMESPACE_SEPARATOR,
+ NamespaceUtils.DEFAULT_NAMESPACE_SEPARATOR_ENCODED))
Review Comment:
I'd agree in general, but what irks me is the fact the that config value is
an URL _encoded_ separator. The client has to know exactly how to apply it to
avoid double encoding :thinking:
With defaults, the onus is completely on the client to produce correct URLs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
