Copilot commented on code in PR #4513: URL: https://github.com/apache/polaris/pull/4513#discussion_r3278065080
########## site/content/downloads/1.5.0/index.md: ########## @@ -50,10 +50,9 @@ Released on May 18th, 2026. #### Breaking changes -- The ExternalCatalogFactory interface has been renamed to FederatedCatalogFactory. Its createCatalog() and createGenericCatalog() method signatures have been extended to include a `catalogProperties` parameter of type `Map<String, String>` for passing through proxy and timeout settings to federated catalog HTTP clients. - The `ConnectionCredentials.of()` method now throws an exception when more than one expiration timestamp property is present in the credentials map. Only a single expiration timestamp is allowed per credentials bundle. - Entity names (namespaces, tables, views, generic tables) submitted to the REST layer are now rejected with HTTP 400 if they are empty, contain a `/`, or have leading/trailing whitespace. Clients that were previously able to create such entities must rename them before upgrading. -- The `MaintenanceService.performMaintenance()` signature now requires an explicit `OptionalLong overrideRunId` argument to supersede the latest unfinished maintenance run. +- Fixed `renameTable` to return HTTP 204 (No Content) instead of 200, as per the Iceberg REST Catalog spec. Review Comment: This item is now listed under “Breaking changes”, but the wording starts with “Fixed…”, which reads like a non-breaking bugfix. Consider rephrasing to make the breaking REST contract change explicit (e.g., “`renameTable` now returns HTTP 204 instead of 200 …”) and, if relevant, briefly call out the client impact. ########## CHANGELOG.md: ########## @@ -48,36 +55,29 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti ### Upgrade notes ### Breaking changes -- The ExternalCatalogFactory interface has been renamed to FederatedCatalogFactory. Its createCatalog() and createGenericCatalog() method signatures have been extended to include a `catalogProperties` parameter of type `Map<String, String>` for passing through proxy and timeout settings to federated catalog HTTP clients. - The `ConnectionCredentials.of()` method now throws an exception when more than one expiration timestamp property is present in the credentials map. Only a single expiration timestamp is allowed per credentials bundle. - Entity names (namespaces, tables, views, generic tables) submitted to the REST layer are now rejected with HTTP 400 if they are empty, contain a `/`, or have leading/trailing whitespace. Clients that were previously able to create such entities must rename them before upgrading. -- The `MaintenanceService.performMaintenance()` signature now requires an explicit `OptionalLong overrideRunId` argument to supersede the latest unfinished maintenance run. +- Fixed `renameTable` to return HTTP 204 (No Content) instead of 200, as per the Iceberg REST Catalog spec. Review Comment: This entry is under “Breaking changes” but is phrased as “Fixed…”, which can be confusing in a breaking-change context. Consider rewording to describe the behavioral change directly (HTTP 200 -> 204) and optionally mention the REST client impact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
