snazy commented on code in PR #4543:
URL: https://github.com/apache/polaris/pull/4543#discussion_r3309147897
##########
persistence/nosql/async/java/src/test/java/org/apache/polaris/nosql/async/java/TestJavaPoolAsyncExec.java:
##########
@@ -143,11 +141,12 @@ public void
immediateTaskRejectedWhenThreadPoolIsSaturated() throws Exception {
});
assertThat(started.await(5_000, MILLISECONDS)).isTrue();
- assertThatThrownBy(() -> executor.submit(() -> "rejected"))
- .isInstanceOf(RejectedExecutionException.class);
+ var delayed = executor.submit(() ->
"delayed").completionStage().toCompletableFuture();
+ assertThat(delayed).isNotDone();
Review Comment:
Not really. The pool has at max one worker thread that's being blocked by
the first task for 5 seconds. The retry is scheduled to run after 100ms, quite
within the "blocked" duration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
