flyrain commented on code in PR #4543:
URL: https://github.com/apache/polaris/pull/4543#discussion_r3312614060
##########
persistence/nosql/async/vertx/src/main/java/org/apache/polaris/nosql/async/vertx/VertxAsyncExec.java:
##########
@@ -264,12 +267,38 @@ void execAsync(long unused) {
if (periodic && !running.compareAndSet(false, true)) {
return;
}
+ submitAsync();
+ }
+
+ @SuppressWarnings("FutureReturnValueIgnored")
+ private void submitAsync() {
try {
var f = executorService.submit(this);
runningFuture.set(f);
VertxAsyncExec.this.taskSubmittedHook(f);
+ } catch (Throwable e) {
Review Comment:
Catching `Throwable` here is broader than `JavaPoolAsyncExec.immediate`
(which catches `RejectedExecutionException`). If this is intentional to absorb
vertx-core surprises, a one-line comment would help; otherwise narrowing to
`RejectedExecutionException` would keep the two impls consistent and avoid
swallowing unrelated bugs as retry signals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
