venkateshwaracholan opened a new pull request, #4580: URL: https://github.com/apache/polaris/pull/4580
<!-- ๐ Describe what changes you're proposing, especially breaking or user-facing changes. ๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more. --> Fixes #3378 This fixes a `ClassCastException` in the JDBC optimized sibling location check when `OPTIMIZED_SIBLING_CHECK=true`. JDBC persistence materializes queried entities as `PolarisBaseEntity`, but the optimized sibling check assumed results could be cast to `LocationBasedEntity`. This caused table creation to fail when optimized sibling checking was enabled. The fix uses the persisted base location property stored on the entity instead of relying on a runtime type cast. Existing overlap detection behavior is preserved. Added regression coverage for JDBC schema versions that support `location_without_scheme`, including both overlapping and non-overlapping sibling location scenarios. ## Checklist - [ ] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [ ] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes # - [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [ ] ๐ก Added comments for complex logic - [ ] ๐งพ Updated `CHANGELOG.md` (if needed) - [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
