venkateshwaracholan commented on code in PR #4580:
URL: https://github.com/apache/polaris/pull/4580#discussion_r3330367106
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -810,8 +811,14 @@ Optional<Optional<String>> hasOverlappingSiblings(
if (!results.isEmpty()) {
StorageLocation entityLocation =
StorageLocation.of(entity.getBaseLocation());
for (PolarisBaseEntity result : results) {
- StorageLocation potentialSiblingLocation =
- StorageLocation.of(((LocationBasedEntity)
result).getBaseLocation());
+ // JDBC materializes persisted rows as PolarisBaseEntity, so use the
stored location
+ // property instead of casting to LocationBasedEntity.
+ String siblingBaseLocation =
+
result.getPropertiesAsMap().get(PolarisEntityConstants.ENTITY_BASE_LOCATION);
Review Comment:
@dimas-b Switched to PolarisEntityUtils.asLocationBasedEntity() as
suggested. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
