venkateshwaracholan opened a new pull request, #4583:
URL: https://github.com/apache/polaris/pull/4583
Fixes #2675
## Summary
Generate JDBC metastore schema-version test subclasses from discovered H2
schema files instead of maintaining one Java test class per schema version.
## Changes
- Add a Gradle `generateSchemaVersionTests` task in
`polaris-relational-jdbc`.
- Discover `schema-v*.sql` files from both `src/main/resources/h2` and
`src/test/resources/h2`.
- Generate `AtomicMetastoreManagerWithJdbcBasePersistenceImplV*SchemaTest`
subclasses automatically.
- Remove the manually maintained `V0` through `V4` schema test classes.
## Validation
Ran:
```bash
./gradlew :polaris-relational-jdbc:test \
--tests
"org.apache.polaris.persistence.relational.jdbc.AtomicMetastoreManagerWithJdbcBasePersistenceImplV*SchemaTest"
## Checklist
- [ ] ๐ก๏ธ Don't disclose security issues! (contact [email protected])
- [ ] ๐ Clearly explained why the changes are needed, or linked related
issues: Fixes #
- [ ] ๐งช Added/updated tests with good coverage, or manually tested (and
explained how)
- [ ] ๐ก Added comments for complex logic
- [ ] ๐งพ Updated `CHANGELOG.md` (if needed)
- [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
