MonkeyCanCode commented on PR #4535: URL: https://github.com/apache/polaris/pull/4535#issuecomment-4609066240
> > > Hi @MonkeyCanCode, thanks for the refactoring. I think the PR goes in the right direction. Moving REST related classes to a common module looks good to me. > > > BTW, here is the Iceberg thread to keep git history, https://lists.apache.org/thread/3qk85db08rvdon15fyfvyf0y4cd3d8sq, and a Iceberg PR for reference, https://github.com/apache/iceberg/pull/12494/commits. > > > > > > Thanks @flyrain . I am working on replacing the regtest with junit directly (#4588). I will come back to this shortly. > > Got it. So yeah. instead of just use `cp spark3.4 spark4.0`, I should just do `git mv spark3.5 spark4.0` then `cp -r spark4.0 spark3.5). This should hopefully retain the history. I will give it a try a bit later this week. So I took a look at this, I see some inconsistency: 3.5: https://github.com/apache/iceberg/blame/main/spark/v3.5/spark-runtime/src/integration/java/org/apache/iceberg/spark/TestRoundTrip.java 4.0: https://github.com/apache/iceberg/blame/main/spark/v4.0/spark-runtime/src/integration/java/org/apache/iceberg/spark/TestRoundTrip.java 4.1: https://github.com/apache/iceberg/blame/main/spark/v4.1/spark-runtime/src/integration/java/org/apache/iceberg/spark/TestRoundTrip.java As you can see from above, 3.5 and 4.1 shared the commit history but not for 4.0. Maybe that is related to what @snazy mentioned about regarding when commits got squash merged, those will get squash away. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
