MonkeyCanCode commented on PR #4535: URL: https://github.com/apache/polaris/pull/4535#issuecomment-4617271013
> > So I took a look at this, I see some inconsistency: 3.5: https://github.com/apache/iceberg/blame/main/spark/v3.5/spark-runtime/src/integration/java/org/apache/iceberg/spark/TestRoundTrip.java 4.0: https://github.com/apache/iceberg/blame/main/spark/v4.0/spark-runtime/src/integration/java/org/apache/iceberg/spark/TestRoundTrip.java 4.1: https://github.com/apache/iceberg/blame/main/spark/v4.1/spark-runtime/src/integration/java/org/apache/iceberg/spark/TestRoundTrip.java > > > > > > As you can see from above, 3.5 and 4.1 shared the commit history but not for 4.0. Maybe that is related to what @snazy mentioned about regarding when commits got squash merged, those will get squash away. Thoughts? > > > > It's possible that squash merging caused that, @huaxingao may know more details. Yes. I didn't see an option to do so during merge. I think we may need to enable that. I will push my local changes soon for this review then do another clean PR with non-squash merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
