ArnavBalyan opened a new pull request, #4629:
URL: https://github.com/apache/polaris/pull/4629
- The system regex checker is incorrectly allowing `system` identifier to
go through
- `\$` is an escaped literal dollar character, not the end anchor.
- Further `[s|S]` is a character class containing `s`, `|`, `S`.
- Corrected the regex, and added unit tests to verify the behaviour.
## Checklist
- [X] ๐ก๏ธ Don't disclose security issues! (contact [email protected])
- [X] ๐ Clearly explained why the changes are needed, or linked related
issues: Fixes #
- [X] ๐งช Added/updated tests with good coverage, or manually tested (and
explained how)
- [X] ๐ก Added comments for complex logic
- [X] ๐งพ Updated `CHANGELOG.md` (if needed)
- [X] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
