dimas-b commented on code in PR #4629:
URL: https://github.com/apache/polaris/pull/4629#discussion_r3377555467
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisManagementServiceIntegrationTest.java:
##########
@@ -235,13 +235,7 @@ public void testCreateCatalogWithInvalidName() {
String longInvalidName = newRandomString(MAX_IDENTIFIER_LENGTH + 1);
List<String> invalidCatalogNames =
- Arrays.asList(
- longInvalidName,
- "",
- "system$catalog1",
- "SYSTEM$TestCatalog",
- "System$test_catalog",
- " SysTeM$ test catalog");
+ Arrays.asList(longInvalidName, "", "system", "SYSTEM", "System",
"SysTeM");
Review Comment:
Let's not change the intended validation behaviour in this PR.
Still, the `|` chars inside RegEx `[]` brackets look like a pure bug to me,
so those would be worth fixing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
